Wireshark · Wireshark-commits: [Wireshark-commits] master bb0c175: Strengthen the heuristics for pcap subtypes.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb0c17546f8caf817f767ab48b12c66572da4f08
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bb0c175 by Guy Harris (guy@xxxxxxxxxxxx):

    Strengthen the heuristics for pcap subtypes.
    
    When trying to guess what type of capture a file is, look for as many
    bogosities (caplen > len, microseconds >= 10^6/nanoseconds >= 10^9,
    too-high caplen, too-high original len, caplen > snapshort length), to
    increase the chances of guessing correctly.
    
    (Every time somebody uses 0xa1b2c3d4 as the magic number for a capture
    file that isn't standard pcap format, God kills a kitten.  Please, think
    of the kittens.)
    
    Change-Id: I3f397d598ed61dc82e2832be30452ebe8ace98e8
    Reviewed-on: https://code.wireshark.org/review/3808
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  28bea6f   Add captype to the CMake options so it gets built if required
    adds  bb0c175   Strengthen the heuristics for pcap subtypes.


Summary of changes:
 wiretap/libpcap.c |  431 +++++++++++++++++++++++++----------------------------
 1 file changed, 205 insertions(+), 226 deletions(-)