Wireshark-commits: [Wireshark-commits] master 2d74838: Decode the 3GPP MSISDN AVP using the E.164 r
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 22 Aug 2014 19:17:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d74838e473a3e3414addb73c892efa470c4c0f1
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2d74838 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Decode the 3GPP MSISDN AVP using the E.164 routines.
    
    Rename dissect_e164_utf8_number() to dissect_e164_msisdn() and give it an
    'encoding' argument.
    
    Change-Id: I49cf5d2b24b44a0e69427ceae331f378024391c5
    Reviewed-on: https://code.wireshark.org/review/3796
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  923ba9d   Fix a comment typo: tvb_bcd_dig_to_wmem_packet_str() returns a WMEM-allocated string, not an EP-allocated one.
    adds  2d74838   Decode the 3GPP MSISDN AVP using the E.164 routines.


Summary of changes:
 epan/dissectors/packet-diameter.c      |    2 +-
 epan/dissectors/packet-diameter_3gpp.c |   30 +++---------------------------
 epan/dissectors/packet-e164.c          |   19 +++++++++++++++----
 epan/dissectors/packet-e164.h          |    2 +-
 4 files changed, 20 insertions(+), 33 deletions(-)