Wireshark-commits: [Wireshark-commits] master 945b371: Eliminate proto_tree_add_text from some diss
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 Aug 2014 07:53:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=945b371a259ef8ed4fb94b13798162e688234f64
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

945b371 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from some dissectors.
    
    Other minor cleanup while in the neighborhood.
    
    Change-Id: I77cac916d617f56f92f686e9cd9f15fba058facf
    Reviewed-on: https://code.wireshark.org/review/3675
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  83ad0d0   Fix TRILL LSP display issues
    adds  945b371   Eliminate proto_tree_add_text from some dissectors.


Summary of changes:
 epan/dissectors/packet-nb_rtpmux.c   |    5 +-
 epan/dissectors/packet-nbipx.c       |  127 +++++++-------
 epan/dissectors/packet-ncp-nmas.c    |   26 +--
 epan/dissectors/packet-ncp-sss.c     |   16 +-
 epan/dissectors/packet-ncp.c         |   12 +-
 epan/dissectors/packet-ndmp.c        |  313 +++++++++++++++-------------------
 epan/dissectors/packet-ndps.c        |   76 ++++-----
 epan/dissectors/packet-negoex.c      |    8 +-
 epan/dissectors/packet-netanalyzer.c |   28 +--
 epan/dissectors/packet-netlink.c     |    6 +-
 epan/dissectors/packet-noe.c         |   46 +++--
 epan/dissectors/packet-nt-tpcp.c     |  113 ++++++------
 epan/dissectors/packet-ntlmssp.c     |   23 +--
 epan/dissectors/packet-ntp.c         |   71 ++++----
 epan/dissectors/packet-openflow.c    |   15 +-
 epan/dissectors/packet-openflow_v1.c |   32 +++-
 16 files changed, 468 insertions(+), 449 deletions(-)