Wireshark-commits: [Wireshark-commits] master b8293f9: If we don't find a NetScaler signature, don'
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 Aug 2014 00:33:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b8293f95ad18bc1cc00363627471c880d0f4e5a2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b8293f9 by Guy Harris (guy@xxxxxxxxxxxx):

    If we don't find a NetScaler signature, don't report an error.
    
    It's *NOT* an error; it's just a file that isn't a NetScaler file.
    Otherwise, we report errors on files that should just be passed on to
    other open routines.
    
    Also, NetScaler files are *NOT* text files, and we should *NOT* use
    ".txt" as the suffix.
    
    Change-Id: If001abbbbc3de3ea27439a44a47ce1d6071d38ae
    Reviewed-on: https://code.wireshark.org/review/3678
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6a82672   Return 0, not -1, for "this isn't my type of file".
    adds  b8293f9   If we don't find a NetScaler signature, don't report an error.


Summary of changes:
 wiretap/file_access.c |    2 +-
 wiretap/netscaler.c   |   15 ++++++++-------
 2 files changed, 9 insertions(+), 8 deletions(-)