Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 e354501: packet-hislip.c: Fix various bugs and deficiencies

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e354501ca4681c5291764d928cfd90bd7171d1bf
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

e354501 by Bill Meier (wmeier@xxxxxxxxxxx):

    packet-hislip.c: Fix various bugs and deficiencies
    
    - Remove an incorrect call to conversation_new()
      (which messed up TCP sequence number analysis).
    - hislip Request/Response analysis must be done during 'pass1'
      (i.e. when 'flags.visited == 0');
      Not doing so caused various problems including
       tshark '1 pass' poor dissection.
    - Remove 'if (tree)' around a call to expert_...().
    - Don't show "unknown" for Async/Sync when the value is actually known.
    - Simplify some code.
    - Mark a field as GENERATED.
    
    Change-Id: I286c12f52e5f73377bed3a2792f3ff0003e2785f
    Reviewed-on: https://code.wireshark.org/review/3541
    Petri-Dish: Bill Meier <wmeier@xxxxxxxxxxx>
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    (cherry picked from commit e7301a15ab814e4070f918bba8561f291623faae)
    Reviewed-on: https://code.wireshark.org/review/3543
    

Actions performed:

    from  e1c548e   [Automatic manuf, services and enterprise-numbers update for 2014-08-10]
    adds  e354501   packet-hislip.c: Fix various bugs and deficiencies


Summary of changes:
 epan/dissectors/packet-hislip.c |  130 ++++++++++++++++++---------------------
 1 file changed, 60 insertions(+), 70 deletions(-)