Wireshark-commits: [Wireshark-commits] master d13b031: packet-lg8979.c: Various minor changes
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 10 Aug 2014 23:01:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d13b0313db6fef88bb08844d8b09e7ebfa081db1
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d13b031 by Bill Meier (wmeier@xxxxxxxxxxx):

    packet-lg8979.c: Various minor changes
    
    - tvb_length() --> tvb_reported_length();
    - Add an XXX comment re use of 'get_length' for tcp_dissect_pdus();
    - Remove a few unneeded initializers;
    - Simplify/adjust code in a few places;
    - Remove some boilerplate comments;
    - Reformat some whitespace and long-lines.
    
    Change-Id: I17b9750cc1bdb5140edc28efbae5bf0f6ec23b6e
    Reviewed-on: https://code.wireshark.org/review/3538
    Petri-Dish: Bill Meier <wmeier@xxxxxxxxxxx>
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  52ddc45   packet-epon.c: remove an unneeded #include
    adds  d13b031   packet-lg8979.c: Various minor changes


Summary of changes:
 epan/dissectors/packet-lg8979.c |  175 +++++++++++++++++++++------------------
 1 file changed, 93 insertions(+), 82 deletions(-)