Wireshark-commits: [Wireshark-commits] master 601d99d: MySQL: Request Unknown (133) (SSL: Handshake
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 5 Aug 2014 11:52:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=601d99d77c4e0fe8b7024b41dc3bdb2f009ecaaa
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

601d99d by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    MySQL: Request Unknown (133) (SSL: Handshake response packet)
    
    After the MySQL protocol has established a SSL connection the first packet is a HandshakeResponse packet (aka Login Request).
    
    http://dev.mysql.com/doc/internals/en/ssl.html
    http://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::HandshakeResponse
    
    The loginrequest within the SSL stream is not packet_number 1. (it however is the first packet in the ssl stream)
    
    Issue found by Daniël van Eeden
    
    Change-Id: Ic6110c38f7206a9788158c5c6861064939644221
    Ping-Bug:10338
    Reviewed-on: https://code.wireshark.org/review/3408
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Daniël van Eeden <wireshark@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  f080b43   Windows: Manage remote interfaces
    adds  601d99d   MySQL: Request Unknown (133) (SSL: Handshake response packet)


Summary of changes:
 epan/dissectors/packet-mysql.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)