Wireshark-commits: [Wireshark-commits] master bbda3dd: Write out decode_as entries from the actual
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 4 Aug 2014 23:38:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bbda3dd7c1998b98202af8b24de415412298db86
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bbda3dd by Guy Harris (guy@xxxxxxxxxxxx):

    Write out decode_as entries from the actual dissector tables.
    
    Have a save_decode_as_entries() routine in ui/decode_as_utils.c, that
    does all the work of saving the entries by iterating through all the
    changed entries with dissector_all_tables_foreach_changed().
    
    When doing so, write out the selector for integral values in decimal, as
    older versions of Wireshark only handled decimal values, and some of
    those older versions are EOLed and won't be fixed.
    
    Change-Id: I2dab461604524b98e3515867839a4b86c86c5d7b
    Reviewed-on: https://code.wireshark.org/review/3426
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ce7b041   Squelch a compiler warning.
    adds  bbda3dd   Write out decode_as entries from the actual dissector tables.


Summary of changes:
 ui/decode_as_utils.c       |   82 +++++++++++++++++++++++++++++++++++---------
 ui/decode_as_utils.h       |   23 +++----------
 ui/gtk/decode_as_dlg.c     |   22 +-----------
 ui/qt/decode_as_dialog.cpp |   14 +-------
 4 files changed, 72 insertions(+), 69 deletions(-)