Wireshark-commits: [Wireshark-commits] master 4a2e968: MySQL: decoding response fails
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 4 Aug 2014 19:22:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a2e968ff35b8b10f1c601382e0a79087687bb88
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a2e968 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    MySQL: decoding response fails
    
    MySQL Response packets within an SSL stream are not correctly decoded.
    
    When not using SSL:
    - Decoding works
    - Multiple MySQL protocol entries per frame
    - Info==Response
    
    With SSL:
    - Decoding partly works
    - One MySQL protocol entry per fram
    - Info==Response Tabular
    
    From me:
    call dissect_mysql (with tcp_dissect_pdus..) and not dissect_mysql_pdu !
    
    Bug: 10339
    Change-Id: I253f6683105ed23b49a72865fea005e31e2594d8
    Reviewed-on: https://code.wireshark.org/review/3412
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  c540e55   DNS: Fix minor typo (Missing a space...)
    adds  4a2e968   MySQL: decoding response fails


Summary of changes:
 epan/dissectors/packet-mysql.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)