Wireshark-commits: [Wireshark-commits] master-1.12 becb4d7: Only fake an item by returning 'tree' i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 4 Aug 2014 17:22:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=becb4d7837dbb506ec6359a72f7adbf0166ae0a2
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

becb4d7 by Evan Huus (eapache@xxxxxxxxx):

    Only fake an item by returning 'tree' if they use the same TVB
    
    Otherwise the offsets will be wrong when calling, e.g. proto_item_set_end.
    
    Bug:10329
    Change-Id: I5ae0c660af90678e446817b65f83c075e7c0b84e
    Reviewed-on: https://code.wireshark.org/review/3340
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  087b6a6   Some other places that needed buffer_ -> tagbuffer_.
    adds  becb4d7   Only fake an item by returning 'tree' if they use the same TVB


Summary of changes:
 epan/proto.c |   89 +++++++++++++++++++++++++++++-----------------------------
 1 file changed, 45 insertions(+), 44 deletions(-)