Wireshark · Wireshark-commits: [Wireshark-commits] master 2d50397: paltalk: fix undefined behavior (shift out of range)

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d50397518a2e9b9ea9c49482b99426fd4e1f1de
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2d50397 by Peter Wu (peter@xxxxxxxxxxxxx):

    paltalk: fix undefined behavior (shift out of range)
    
    The shift `(gint32)0xFF << 24` invokes undefined behavior as it may not
    fit in a signed integer. Fix this by explicitly casting 0xFF as
    unsigned. Caught by `clang -fsanitize=undefined`.
    
    While at it, convert to tvb_captured_length and add modelines.
    
    Change-Id: I241ff8ed91815369ec0c19719750cee4b6b12343
    Reviewed-on: https://code.wireshark.org/review/3311
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  0b23e0f   HTTP2: Add a preference to enable/disable HTTP2 (weak) heuristics
    adds  2d50397   paltalk: fix undefined behavior (shift out of range)


Summary of changes:
 epan/dissectors/packet-paltalk.c |   16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)