Wireshark-commits: [Wireshark-commits] master f4d2421: Add a routine to check whether all bytes imp
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 2 Aug 2014 18:33:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f4d24216bea6c955e39b08ff8155f6cdd4a1183f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f4d2421 by Guy Harris (guy@xxxxxxxxxxxx):

    Add a routine to check whether all bytes implied by a 64-bit length exist.
    
    This lets us blow up with oversized 64-bit length values, before casting
    them to the 31-bit lengths we can actually handle in Wireshark, rather
    than blindly casting them with weird results.
    
    Use that in the MySQL dissector, and, if we get past the test, cast the
    lengths to int to squelch warnings.
    
    Change-Id: I3a5e9bd0027fa4ddcb9622f77952dba8f6b23c27
    Reviewed-on: https://code.wireshark.org/review/3362
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d888087   MySQL: Support authplugin and connattrs
    adds  f4d2421   Add a routine to check whether all bytes implied by a 64-bit length exist.


Summary of changes:
 epan/dissectors/packet-mysql.c |    9 ++++++---
 epan/tvbuff.c                  |   18 ++++++++++++++++++
 epan/tvbuff.h                  |    6 ++++++
 3 files changed, 30 insertions(+), 3 deletions(-)