Wireshark-commits: [Wireshark-commits] master 69d0788: CompiledFilterOutput dialog fixes and update
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 2 Aug 2014 00:50:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=69d0788875b81b2cdd0c751f00eb5b20944ffe15
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

69d0788 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    CompiledFilterOutput dialog fixes and updates.
    
    Apply a layout to the "Compiled Filter Output" dialog. Render the filter
    as monospaced text.
    
    Don't add an "expert OK" icon to the list. It doesn't seem to indicate
    any sort of status.
    
    Use a "Close" button instead of "OK". According to
    
    http://uxmovement.com/buttons/why-the-ok-button-is-no-longer-okay/
    
    "OK" implies we're going to perform some sort of action.
    
    Add a "Copy" button while we're here.
    
    Change-Id: Ia63f3032916e322fa9f4f2d465140b128b4f8078
    Reviewed-on: https://code.wireshark.org/review/3338
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  45f3dee   Fixing indentation with tabs in isis dissector
    adds  69d0788   CompiledFilterOutput dialog fixes and updates.


Summary of changes:
 ui/qt/capture_interfaces_dialog.cpp |    1 -
 ui/qt/compiled_filter_output.cpp    |   36 +++++++++++++++---
 ui/qt/compiled_filter_output.h      |    4 +-
 ui/qt/compiled_filter_output.ui     |   71 ++++++++++++++---------------------
 4 files changed, 62 insertions(+), 50 deletions(-)