Wireshark · Wireshark-commits: [Wireshark-commits] master 84e2abc: tcp: detect invalid window scale shift value

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=84e2abc927f038fcec2fd0bc66db2b1d93e7e06c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

84e2abc by Peter Wu (peter@xxxxxxxxxxxxx):

    tcp: detect invalid window scale shift value
    
    According to RFC 1323, the window scale shift value must not exceed 14.
    Detect this and cap at 14 to prevent undefined behavior (shifting by a
    too large value).
    
    Caught by `clang -fsanitize=undefined`.
    
    Change-Id: I1acad252b86c7f23e497575b48d9496346327e00
    Reviewed-on: https://code.wireshark.org/review/3312
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  7f9fdbb   Add wireshark.pc.in to the source distribution (needed for cmake).
    adds  84e2abc   tcp: detect invalid window scale shift value


Summary of changes:
 epan/dissectors/packet-tcp.c |   15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)