Wireshark-commits: [Wireshark-commits] master efafca7: Drop privileges very early on.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 30 Jun 2014 23:12:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=efafca71a338b4b938fea68429ea6871f9371673
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

efafca7 by Guy Harris (guy@xxxxxxxxxxxx):

    Drop privileges very early on.
    
    TShark relies on dumpcap to capture packets, and TFShark doesn't even do
    packet capturing (it dissects files, not network traffic), so neither of
    them need, or should run with, special privileges.  If you *must* run
    with special privileges in order to capture, grant those privileges to
    dumpcap, which has a *lot* fewer lines of code than libwireshark and
    TShark/TFShark.
    
    Change-Id: I8f8fedead355ca163895e025df37240d2f232ba4
    Reviewed-on: https://code.wireshark.org/review/2736
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ac88f71   Clean up a comment.
    adds  efafca7   Drop privileges very early on.


Summary of changes:
 tfshark.c |   14 +++++---------
 tshark.c  |   39 +++++----------------------------------
 2 files changed, 10 insertions(+), 43 deletions(-)