Wireshark-commits: [Wireshark-commits] master efc0a00: We're not currently using dissect_rtcp_psfb_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 27 Jun 2014 07:41:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=efc0a005200cc1148139c678e3af174293ce54c3
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

efc0a00 by Guy Harris (guy@xxxxxxxxxxxx):

    We're not currently using dissect_rtcp_psfb_remb(); #if 0 it out.
    
    Also, note that we need to determine how to handle Application Layer
    Feedback messages based on the SDP setup traffic for the session; recent
    changes disabled dissection of REMB Application Layer Feedback messages
    in favor of MS-RTP Application Layer Feedback messages.  (This is why we
    shouldn't remove dissect_rtcp_psfb_remb() unless REMB isn't being used
    any more.)
    
    Change-Id: Ib320bdf4a64263fdef29fc4ea2583eaae1cc4bee
    Reviewed-on: https://code.wireshark.org/review/2684
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f0d291b   In function 'dissect_rtcp_psfb': packet-rtcp.c:1232: warning: unused parameter 'top_item'
    adds  efc0a00   We're not currently using dissect_rtcp_psfb_remb(); #if 0 it out.


Summary of changes:
 epan/dissectors/packet-rtcp.c |   33 ++++++++++++++++++++++++++++-----
 1 file changed, 28 insertions(+), 5 deletions(-)