Wireshark-commits: [Wireshark-commits] master dbd409d: Fix OS X CMake build.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Jun 2014 07:10:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dbd409d0410dff7f5d4b6bdd7f16d286accf01a5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dbd409d by Guy Harris (guy@xxxxxxxxxxxx):

    Fix OS X CMake build.
    
    I have ***NO*** idea why this makes a difference, but, without this
    change, APPLE_CORE_FOUNDATION_LIBRARY is apparently *not* set correctly
    for wsutil/CMakeLists.txt, and, with this change, it is.  I guess
    there's something magic involved here with "global" CMake variables or
    something crazy such as that.
    
    Change-Id: I7a0046b9c249568cd666720838104f48e854e203
    Reviewed-on: https://code.wireshark.org/review/2612
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4f1d20a   proto_tree_add_uint() takes a value, not an encoding, as an argument.
    adds  dbd409d   Fix OS X CMake build.


Summary of changes:
 Makefile.am                             |    1 +
 cmake/modules/FindOS_X_FRAMEWORKS.cmake |   21 +++++++++++++++++++++
 wsutil/CMakeLists.txt                   |    8 ++++++++
 3 files changed, 30 insertions(+)
 create mode 100644 cmake/modules/FindOS_X_FRAMEWORKS.cmake