Wireshark-commits: [Wireshark-commits] master e68638f: usb iso urbs on linux can't possibly contain
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Jun 2014 03:11:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e68638fe6bbd485676e336abe819d06e88f9a92c
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e68638f by Martin Kaiser (wireshark@xxxxxxxxx):

    usb iso urbs on linux can't possibly contain a setup packet
    
    see mon_bin_event() in the linux kernel where the setup_flag is set only
    for control urbs
    
    clean up various things related to this assertion:
    remove type_2 parameter
    show the iso descriptors in any case
    calculate the end offset correctly, the end offset is the byte after the
    iso data
    
    Change-Id: Iebfbe6443c224a958a1697563aa8fb853d7aa8c2
    Reviewed-on: https://code.wireshark.org/review/2541
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  0f76609   Remove unneeded include <sys/stat.h>
    adds  e68638f   usb iso urbs on linux can't possibly contain a setup packet


Summary of changes:
 epan/dissectors/packet-usb.c |  123 +++++++++++++++++++-----------------------
 1 file changed, 55 insertions(+), 68 deletions(-)