Wireshark-commits: [Wireshark-commits] master c9a5fbe: Optimize sip_is_known_sip_header()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 Jun 2014 14:42:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c9a5fbeb1da9b5566ac9ac36bfdcdee6172ef5c8
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c9a5fbe by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):

    Optimize sip_is_known_sip_header()
    
    Profling SIP shows that gperf generated hashing code, is
    3 times faster than using GHashTable & g_str_hash/_equal()
    
    This result in about 1% improve of whole dissection (sip traffic with filter).
    
    Change-Id: Id6bf64bacd872e2d1c30a1b6356db444b25ba326
    Reviewed-on: https://code.wireshark.org/review/2116
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  eaf6e55   Fix a typo.
    adds  c9a5fbe   Optimize sip_is_known_sip_header()


Summary of changes:
 epan/CMakeLists.txt                   |    1 +
 epan/dissectors/Makefile.common       |    2 +
 epan/dissectors/packet-sip-hdrs.c     |  459 +++++++++++++++++++++++++++++++++
 epan/dissectors/packet-sip-hdrs.gperf |  161 ++++++++++++
 epan/dissectors/packet-sip-hdrs.h     |  163 ++++++++++++
 epan/dissectors/packet-sip.c          |  296 +--------------------
 6 files changed, 788 insertions(+), 294 deletions(-)
 create mode 100644 epan/dissectors/packet-sip-hdrs.c
 create mode 100644 epan/dissectors/packet-sip-hdrs.gperf
 create mode 100644 epan/dissectors/packet-sip-hdrs.h