Wireshark-commits: [Wireshark-commits] master 6e0be01: Add col_append_lstr(), speedup column genera
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 Jun 2014 03:34:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6e0be0173b2037df2653e2a9d47e0213eda386f7
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6e0be01 by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):

    Add col_append_lstr(), speedup column generation for TCP.
    
    When dissecting with columns TCP dissector spends
    around 1/4 time in col_append_fstr(), add col_append_lstr()
    and do formatting by ourselves.
    
    Change-Id: If90bc26242761884b4991e8db0db62c8f9e32690
    Reviewed-on: https://code.wireshark.org/review/2527
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ab6a45a   Get rid of set-but-not-used variable.
    adds  6e0be01   Add col_append_lstr(), speedup column generation for TCP.


Summary of changes:
 epan/column-utils.c          |   39 +++++++++++++++++++++++++++++++++++++++
 epan/column-utils.h          |    6 ++++++
 epan/dissectors/packet-tcp.c |   23 ++++++++++++++++++-----
 3 files changed, 63 insertions(+), 5 deletions(-)