Wireshark-commits: [Wireshark-commits] master e02c66f: Check constraints for OSPFv2 LSAs: 1 Router
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 21 Jun 2014 18:17:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e02c66f157504fafed572840ad2024c7f6756ddc
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e02c66f by Anish Bhatt (anish@xxxxxxxxxxx):

    Check constraints for OSPFv2 LSAs:
    1 Router LSA: >= 24 bytes (>= 0 link descriptor(s) required)
    2 Network LSA: >= 28 bytes (>= 1 router-ID(s) required)
    3 Summary LSA: >= 28 bytes (>= 1 TOS metric block(s) required)
    4 Summary LSA: >= 28 bytes (>= 1 TOS metric block(s) required)
    5 AS-External LSA: >= 36 bytes (>= 1 TOS forwarding block(s) required)
    7 NSSA LSA: >= 36 bytes (>= 1 TOS forwarding block(s) required)
    9 Opaque Link LSA: >= 20 bytes
    10 Opaque Area LSA: >= 20 bytes
    11 Opaque AS LSA: >= 20 bytes
    
    as described in Bug 6302
    
    for all other types including unknown, check for minimum length of 20
    
    Change-Id: I93451d99a93213b4ded8157cecd54b0a6221d351
    Signed-off-by: Anish Bhatt <anish@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/2292
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  554c902   Move the Windows build target OS definitions to Win XP
    adds  e02c66f   Check constraints for OSPFv2 LSAs: 1 Router LSA: >= 24 bytes (>= 0 link descriptor(s) required) 2 Network LSA: >= 28 bytes (>= 1 router-ID(s) required) 3 Summary LSA: >= 28 bytes (>= 1 TOS metric block(s) required) 4 Summary LSA: >= 28 bytes (>= 1 TOS metric block(s) required) 5 AS-External LSA: >= 36 bytes (>= 1 TOS forwarding block(s) required) 7 NSSA LSA: >= 36 bytes (>= 1 TOS forwarding block(s) required) 9 Opaque Link LSA: >= 20 bytes 10 Opaque Area LSA: >= 20 byt [...]


Summary of changes:
 epan/dissectors/packet-ospf.c |   48 +++++++++++++++++++++++++++++++++++------
 1 file changed, 41 insertions(+), 7 deletions(-)