Wireshark-commits: [Wireshark-commits] master 312ed10: Add --help and --version long options.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Jun 2014 19:19:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=312ed10900df878ef8476febe72c8f1308aba106
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

312ed10 by Guy Harris (guy@xxxxxxxxxxxx):

    Add --help and --version long options.
    
    Also, make the convention for long-only options be that their
    case-statement values start at 128, so they avoid colliding with any
    ASCII code points, including control characters.
    
    Make the tables of long options "static const" while we're at it, and
    get rid of unnecessary casts.
    
    Change-Id: I55702a85e9bc078b1cd0f2803ebb68a710405bab
    Reviewed-on: https://code.wireshark.org/review/2491
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6808afd   TCP: update the list of options and put Kind and Length items in the right subtree
    adds  312ed10   Add --help and --version long options.


Summary of changes:
 capture_opts.h |   31 +++++++++++++++++++++++--------
 dumpcap.c      |    8 +++++---
 tshark.c       |    4 +++-
 ui/qt/main.cpp |    6 ++++--
 4 files changed, 35 insertions(+), 14 deletions(-)