Wireshark-commits: [Wireshark-commits] master ce3d2ff: Rename dissector_add_handle() to dissector_a
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Jun 2014 16:43:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce3d2ff3ded3eccb9d64c6cb46c64ad8f8a837b9 Submitter: Guy Harris (guy@xxxxxxxxxxxx) Changed: branch: master Repository: wireshark Commits: ce3d2ff by Guy Harris (guy@xxxxxxxxxxxx): Rename dissector_add_handle() to dissector_add_for_decode_as(). Hopefully that name makes it clear what the routiner's purpose is, and will encourage people to use it rather than using dissector_add_uint() with a bogus integer value. Change-Id: Ic5be456d0ad40b176aab01712ab7b13aed5de2a8 Reviewed-on: https://code.wireshark.org/review/2483 Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx> Actions performed: from 4df6b51 remove duplicate offset=0 adds ce3d2ff Rename dissector_add_handle() to dissector_add_for_decode_as(). Summary of changes: asn1/h245/packet-h245-template.c | 4 ++-- asn1/h283/packet-h283-template.c | 2 +- asn1/lcsap/packet-lcsap-template.c | 2 +- asn1/lte-rrc/packet-lte-rrc-template.c | 2 +- asn1/nbap/packet-nbap-template.c | 4 ++-- asn1/s1ap/packet-s1ap-template.c | 2 +- asn1/x2ap/packet-x2ap-template.c | 2 +- epan/dissectors/packet-6lowpan.c | 2 +- epan/dissectors/packet-acn.c | 2 +- epan/dissectors/packet-adb_cs.c | 2 +- epan/dissectors/packet-artnet.c | 2 +- epan/dissectors/packet-ber.c | 2 +- epan/dissectors/packet-bfcp.c | 4 ++-- epan/dissectors/packet-bitcoin.c | 2 +- epan/dissectors/packet-brp.c | 2 +- epan/dissectors/packet-bt-dht.c | 2 +- epan/dissectors/packet-bt-utp.c | 2 +- epan/dissectors/packet-bt3ds.c | 2 +- epan/dissectors/packet-btavctp.c | 2 +- epan/dissectors/packet-btavdtp.c | 6 +++--- epan/dissectors/packet-btbnep.c | 2 +- epan/dissectors/packet-bthcrp.c | 4 ++-- epan/dissectors/packet-bthfp.c | 2 +- epan/dissectors/packet-bthid.c | 2 +- epan/dissectors/packet-bthsp.c | 2 +- epan/dissectors/packet-btmcap.c | 4 ++-- epan/dissectors/packet-btobex.c | 6 +++--- epan/dissectors/packet-btrfcomm.c | 8 ++++---- epan/dissectors/packet-btsap.c | 2 +- epan/dissectors/packet-btsdp.c | 2 +- epan/dissectors/packet-ccsds.c | 2 +- epan/dissectors/packet-cfdp.c | 2 +- epan/dissectors/packet-cigi.c | 4 ++-- epan/dissectors/packet-cimd.c | 2 +- epan/dissectors/packet-cisco-wids.c | 2 +- epan/dissectors/packet-ctdb.c | 2 +- epan/dissectors/packet-dbus.c | 2 +- epan/dissectors/packet-dtls.c | 4 ++-- epan/dissectors/packet-ehs.c | 2 +- epan/dissectors/packet-erldp.c | 2 +- epan/dissectors/packet-eth.c | 2 +- epan/dissectors/packet-fcgi.c | 2 +- epan/dissectors/packet-fcip.c | 2 +- epan/dissectors/packet-fix.c | 2 +- epan/dissectors/packet-gdb.c | 2 +- epan/dissectors/packet-geneve.c | 2 +- epan/dissectors/packet-giop.c | 2 +- epan/dissectors/packet-h223.c | 4 ++-- epan/dissectors/packet-h245.c | 4 ++-- epan/dissectors/packet-h283.c | 2 +- epan/dissectors/packet-hci_usb.c | 2 +- epan/dissectors/packet-hdfs.c | 2 +- epan/dissectors/packet-hdfsdata.c | 2 +- epan/dissectors/packet-http2.c | 2 +- epan/dissectors/packet-ifcp.c | 2 +- epan/dissectors/packet-interlink.c | 2 +- epan/dissectors/packet-ip.c | 2 +- epan/dissectors/packet-iscsi.c | 2 +- epan/dissectors/packet-lbmpdmtcp.c | 2 +- epan/dissectors/packet-lbmr.c | 2 +- epan/dissectors/packet-lbtrm.c | 2 +- epan/dissectors/packet-lbtru.c | 2 +- epan/dissectors/packet-lbttcp.c | 2 +- epan/dissectors/packet-lcsap.c | 2 +- epan/dissectors/packet-lge_monitor.c | 2 +- epan/dissectors/packet-logcat.c | 2 +- epan/dissectors/packet-lsc.c | 4 ++-- epan/dissectors/packet-lte-rrc.c | 2 +- epan/dissectors/packet-lwm.c | 2 +- epan/dissectors/packet-miop.c | 2 +- epan/dissectors/packet-mp2t.c | 2 +- epan/dissectors/packet-mq.c | 2 +- epan/dissectors/packet-mqtt.c | 2 +- epan/dissectors/packet-msrp.c | 2 +- epan/dissectors/packet-nasdaq-soup.c | 2 +- epan/dissectors/packet-nat-pmp.c | 2 +- epan/dissectors/packet-nb_rtpmux.c | 2 +- epan/dissectors/packet-nbap.c | 4 ++-- epan/dissectors/packet-netdump.c | 2 +- epan/dissectors/packet-newmail.c | 2 +- epan/dissectors/packet-nwmtp.c | 3 +-- epan/dissectors/packet-openwire.c | 2 +- epan/dissectors/packet-osc.c | 3 ++- epan/dissectors/packet-osi.c | 2 +- epan/dissectors/packet-pana.c | 2 +- epan/dissectors/packet-pdc.c | 2 +- epan/dissectors/packet-pgm.c | 4 ++-- epan/dissectors/packet-pw-atm.c | 8 ++++---- epan/dissectors/packet-pw-cesopsn.c | 4 ++-- epan/dissectors/packet-pw-eth.c | 6 +++--- epan/dissectors/packet-pw-fr.c | 2 +- epan/dissectors/packet-pw-hdlc.c | 4 ++-- epan/dissectors/packet-pw-satop.c | 4 ++-- epan/dissectors/packet-rdt.c | 2 +- epan/dissectors/packet-redbackli.c | 2 +- ... 39 lines suppressed ...
- Prev by Date: [Wireshark-commits] master 4df6b51: remove duplicate offset=0
- Next by Date: [Wireshark-commits] master e9424fa: One more change to dissector_add_for_decode_as.
- Previous by thread: [Wireshark-commits] master 4df6b51: remove duplicate offset=0
- Next by thread: [Wireshark-commits] master e9424fa: One more change to dissector_add_for_decode_as.
- Index(es):