Wireshark-commits: [Wireshark-commits] master 0b245a4: Use the same offset += rtnValue logic for al
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Jun 2014 18:22:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b245a4cf8a46110ef0803e091e11fd894e017b2
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0b245a4 by Anish Bhatt (anish@xxxxxxxxxxx):

    Use the same offset += rtnValue logic for all TLV types, instead of a special case for chassis, port & ttl.
    I've avoided using any mathematical checks even though tlv type vals increase linearly just in case they change in the future.
    
    Change-Id: I0ec7021df5b91543e12edf9ba8d9c4ac44ecb11c
    Signed-off-by: Anish Bhatt <anish@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/2193
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  3adc5b8   To make a dissector available for Decode As, just use dissector_add_handle().
    adds  0b245a4   Use the same offset += rtnValue logic for all TLV types, instead of a special case for chassis, port & ttl. I've avoided using any mathematical checks even though tlv type vals increase linearly just in case they change in the future.


Summary of changes:
 epan/dissectors/packet-lldp.c |   22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)