Wireshark-commits: [Wireshark-commits] master 5844e12: Optimize dissect_sip_uri()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Jun 2014 00:10:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5844e129891e39beeab038abfe8a7cc7bfb08ad1
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5844e12 by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):

    Optimize dissect_sip_uri()
    
    - Combine tvb_find_guint8() for comma, semicolon into one tvb_pbrk_guint8()
    
    - Instead of fetching each character use tvb_pbrk_guint8() to fast
      forward.
    
    - Remove not needed tvb_find_guint8() call, as the result is discarded.
    
    Change-Id: I38d6775b187146656d47cea9b64f8e0ccad18d36
    Reviewed-on: https://code.wireshark.org/review/2384
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  153793a   Remove svn $Id$ keyword in Lua scripts
    adds  5844e12   Optimize dissect_sip_uri()


Summary of changes:
 epan/dissectors/packet-sip.c |   63 ++++++++++++++++++++----------------------
 1 file changed, 30 insertions(+), 33 deletions(-)