Wireshark-commits: [Wireshark-commits] master 54819e5: ssl_parse_key_list() gets called from the UI
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Jun 2014 17:03:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=54819e5699ff021275b0f95c4be826ebb9ff899a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

54819e5 by Guy Harris (guy@xxxxxxxxxxxx):

    ssl_parse_key_list() gets called from the UI, so don't use packet scope.
    
    Instead, explicitly allocate and free the address string.
    
    Using packet scope was causing test failures.
    
    Change-Id: Ie18d2da44d2eec8a92a6a86b0ba883a5525f49cd
    Reviewed-on: https://code.wireshark.org/review/2387
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f2dd6c0   SABP: fix an error spotted by pre-commit hook
    adds  54819e5   ssl_parse_key_list() gets called from the UI, so don't use packet scope.


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)