Wireshark-commits: [Wireshark-commits] master 57b27ec: Optimize tvbparse character set checking.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Jun 2014 05:52:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=57b27ec2508b6f97e7ba9bc44508bcd4426ffa53
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

57b27ec by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):

    Optimize tvbparse character set checking.
    
    This patch makes tvbparse_[not_]chars() to generate
    array of characters which is accepted,
    later this array is checked in cond_chars_common().
    
    This results in nice speedup of XML dissector (~33% for my file).
    
    Change-Id: I62a5585f8bccaaea1a0c49fc70c7552531493442
    Reviewed-on: https://code.wireshark.org/review/2356
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c507304   If we don't check for something, don't print a result.
    adds  57b27ec   Optimize tvbparse character set checking.


Summary of changes:
 epan/tvbparse.c |   90 ++++++++++++++++++-------------------------------------
 1 file changed, 29 insertions(+), 61 deletions(-)