Wireshark-commits: [Wireshark-commits] master-1.12 c0b5d6f: EPL: Duplicated frames
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Jun 2014 18:35:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0b5d6f157d1a4e8fca23b236e6aa94839b4cf31
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

c0b5d6f by Lukas Emersberger (lukas.emersberger@xxxxxxxxxxxxxxxxxxx):

    EPL:  Duplicated frames
    
      The MN interprets the CMD layer data only if the CN increments
      the Send-Sequence-Counter => new data. The MN interprets the
      data only once, if the same frame is sent again the MN ignores
      the data.
    
      The behaviour is described in the powerlink specification 301 v1.2.0
      chapter 6.3.2.3.2.3 Error: Duplication of Frame
      Frames which duplicate previous sent data are now marked as
      duplicated frames.
    
    Signed-off-by: Lukas Emersberger <lukas.emersberger@xxxxxxxxx>
    Change-Id: I9ef24b52712bfd3c735856b0cd5747c47aeef72a
    Reviewed-on: https://code.wireshark.org/review/992
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit 75531b6a40719c9cac603f699f0cdf72159fd518)
    Change-Id: I9ef24b52712bfd3c735856b0cd5747c47aeef72a
    Reviewed-on: https://code.wireshark.org/review/2317
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  1230627   simplify PCR calculation
    adds  c0b5d6f   EPL:  Duplicated frames


Summary of changes:
 epan/dissectors/packet-epl.c |  241 +++++++++++++++++++++++++++++++++++++++---
 1 file changed, 225 insertions(+), 16 deletions(-)