Wireshark-commits: [Wireshark-commits] master-1.12 95cc25a: Move ServiceFault from ComplexType- to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Jun 2014 15:56:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=95cc25a133d114369fbffd2b7cf1dfbc57749cae
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

95cc25a by Hannes Mezger (hannes.mezger@xxxxxxxxxxx):

    Move ServiceFault from ComplexType- to ServiceParser
    
    ServiceFaults are always sent as a service response and never as value, this moves the parsing code to the correct location.
    
    Change-Id: Ida9cb561aa40fcbfc3c0429aed732d108b295138
    Reviewed-on: https://code.wireshark.org/review/2124
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit baa58887886c6bbe24f2894e40a4c0e1bccd5314)
    Reviewed-on: https://code.wireshark.org/review/2171
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3e1eaed   Unify displaying of NodeId
    adds  95cc25a   Move ServiceFault from ComplexType- to ServiceParser


Summary of changes:
 plugins/opcua/opcua_complextypeparser.c    |    9 ---------
 plugins/opcua/opcua_complextypeparser.h    |    1 -
 plugins/opcua/opcua_extensionobjectids.h   |    1 -
 plugins/opcua/opcua_extensionobjecttable.c |    1 -
 plugins/opcua/opcua_serviceids.h           |    1 +
 plugins/opcua/opcua_serviceparser.c        |   10 ++++++++++
 plugins/opcua/opcua_serviceparser.h        |    1 +
 plugins/opcua/opcua_servicetable.c         |    2 ++
 8 files changed, 14 insertions(+), 12 deletions(-)