Wireshark · Wireshark-commits: [Wireshark-commits] master f9b05dc: isakmp: allow IKEv1 decryption with non-PSK authentication

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f9b05dc13213832dba10600bd0116505ed251fec
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f9b05dc by Alex Badea (abadea@xxxxxxxxxxx):

    isakmp: allow IKEv1 decryption with non-PSK authentication
    
    There is a check that disables decryption for non-PSK authentication. It
    has been around ever since its introduction in commit acfe071e (svn
    r17229). As suggested in bug 7951, remove this check to allow decryption
    for e.g. certificates authentication.
    
    Bug: 7951
    Change-Id: I5e98407d0f8dbabac2cdaf632cf0af403192872b
    Signed-off-by: Alex Badea <abadea@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/2297
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f847b92   It's so simple: If we require a package but provide alternative methods of finding the package don't allow the first method to fail terminally. Todo: Fix this in all other places as well.
    adds  f9b05dc   isakmp: allow IKEv1 decryption with non-PSK authentication


Summary of changes:
 epan/dissectors/packet-isakmp.c |    1 -
 1 file changed, 1 deletion(-)