Wireshark · Wireshark-commits: [Wireshark-commits] master 8ff7729: Fix USB Class-Specific Control URB requests

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ff7729ee841d82fa829b2e0124dbafc0d838fc5
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8ff7729 by Sean O. Stalley (sean.stalley@xxxxxxxxx):

    Fix USB Class-Specific Control URB requests
    
    Fixes Bug 10165. (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10165)
    
    The condition that caused the bug is a non-standard URB where the
    length of the tvb is less than the reported length. It will pass the
    tvb_reported_length_remaining() != 0, but fail the assertion in
    tvb_composite_append() (which checks the length value, not reported_length).
    
    This condition appears in a few other locations (where the if statement checks
    reported_length, but the code inside the if statement uses the length value).
    This patch also fixes them.
    
    Also removes depricated calls to tvb_length() & tvb_length_remaining()
    with tvb_captured_length() & tvb_captured_length_remaining(), respectively.
    
    Change-Id: Ie8d50cfb24af62558c905c23c37ec603ce76366f
    Reviewed-on: https://code.wireshark.org/review/2011
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  95065da   Some more SVN->Git.
    adds  8ff7729   Fix USB Class-Specific Control URB requests


Summary of changes:
 epan/dissectors/packet-usb.c |   34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)