Wireshark-commits: [Wireshark-commits] master 97a46ff: Fix bit fields definition in the "DMG Capabi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Jun 2014 18:33:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=97a46ff515d509c1a7450433535dcbf6bcb58840
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

97a46ff by Vladimir Kondratiev (qca_vkondrat@xxxxxxxxxxxxxxxx):

    Fix bit fields definition in the "DMG Capability" IE
    
    Bits in the byte was counted wrong direction;
    bit0 should be LSB (0x01) and bit7 - MSB (0x80)
    Also, all fields are interpreted as little-endian
    
    Change-Id: I3485e8743a156e2e8cb84e726045211f1d332598
    Signed-off-by: Vladimir Kondratiev <qca_vkondrat@xxxxxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/2138
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4a60a30   Rename temp variables to a more human readable form
    adds  97a46ff   Fix bit fields definition in the "DMG Capability" IE


Summary of changes:
 epan/dissectors/packet-ieee80211.c |  219 ++++++++++++++++++------------------
 1 file changed, 112 insertions(+), 107 deletions(-)