Wireshark-commits: [Wireshark-commits] master-1.12 4ac46b6: CAPWAP: Display incorrect value for Wir
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Jun 2014 11:49:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4ac46b6c1103a28397630634ca2042839653df17
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

4ac46b6 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    CAPWAP: Display incorrect value for Wireless IEEE802.11 RSSI and Data Rate
    
    * Wireless data ieee80211 RSSI (dBm) is a signed integer. In the wireless radio the dBm value is negative.
    * Wireless data ieee80211 Data Rate (Mbps) is a 100Kbps. You need divide this value by 10.
    
    Issue found by Massimo Vellucci (SmartCAPWAP)
    
    Change-Id: I04dd8a9e38a5f60ee5bf64cd304db1b11413c809
    Reviewed-on: https://code.wireshark.org/review/2094
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 2f13ccc64c6e38336674d1fd6d13e9ece9efec84)
    Reviewed-on: https://code.wireshark.org/review/2104
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  2724a61   Current test for GIT_DIR introduced in changeset Ie1560c372e23e58fb0e310f681388b5e1a65ba5b doesn't seem to be working correctly on bash 4.3.18 : .git/hooks/pre-commit: line 11: .git: command not found
    adds  4ac46b6   CAPWAP: Display incorrect value for Wireless IEEE802.11 RSSI and Data Rate


Summary of changes:
 epan/dissectors/packet-capwap.c |   19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)