Wireshark-commits: [Wireshark-commits] master b69642d: Misc lldp cleanup. I'm cheating a bit here,
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 6 Jun 2014 23:42:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b69642db300a44c244ccbc641facc9cb0c86d072
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b69642d by Anish Bhatt (anish@xxxxxxxxxxx):

    Misc lldp cleanup.
    I'm cheating a bit here, hf_media_loc_long & hf_media_loc_lat need a 5byte bitmask, but the bitmask field in hf is restricted to guint32
    
    Change-Id: I7e044fc680bb947973e437fc66057488a8deee67
    Signed-off-by: Anish Bhatt <anish@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/2012
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  3169939   Moved dissection of setup field to own function
    adds  b69642d   Misc lldp cleanup. I'm cheating a bit here, hf_media_loc_long & hf_media_loc_lat need a 5byte bitmask, but the bitmask field in hf is restricted to guint32


Summary of changes:
 epan/dissectors/packet-lldp.c |   71 ++++++++++++++++++++++-------------------
 1 file changed, 39 insertions(+), 32 deletions(-)