Wireshark-commits: [Wireshark-commits] master 29222ab: Add Object (file) export for files transferr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 5 Jun 2014 18:00:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29222aba7c110c766f752800c2f2a4a4b5b51271
Submitter: Martin Mathieson (martin.r.mathieson@xxxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

29222ab by Martin Mathieson (martin.r.mathieson@xxxxxxxxxxxxxx):

    Add Object (file) export for files transferred over TFTP.
    Updated following review comments.
    
    Change-Id: I56e70d8f8e332d2aea604ceec16c980ad890fa58
    Reviewed-on: https://code.wireshark.org/review/1885
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  6ac68b1   When have more than one SDU in the same RLC PDU, make sure output from all of them stays in the INFO column
    adds  29222ab   Add Object (file) export for files transferred over TFTP. Updated following review comments.


Summary of changes:
 epan/dissectors/packet-tftp.c                   |  134 +++++++++++++++++++++-
 epan/dissectors/{packet-dcm.h => packet-tftp.h} |   32 +++---
 ui/Makefile.common                              |    1 +
 ui/export_object.h                              |    3 +
 ui/export_object_tftp.c                         |  139 +++++++++++++++++++++++
 ui/gtk/export_object_dlg.c                      |    7 ++
 ui/gtk/export_object_dlg.h                      |    1 +
 ui/gtk/main_menubar.c                           |    3 +-
 8 files changed, 302 insertions(+), 18 deletions(-)
 copy epan/dissectors/{packet-dcm.h => packet-tftp.h} (69%)
 create mode 100644 ui/export_object_tftp.c