Wireshark-commits: [Wireshark-commits] master 5c48774: sip: avoid calling tvb_format_text() when tr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 5 Jun 2014 11:48:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5c48774a0163ee3e3a2ff1bf41196054695a45da
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5c48774 by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):

    sip: avoid calling tvb_format_text() when tree is not visible.
    
    sip dissector when filtering spends ~5% of Ir in tvb_format_text(),
    avoid calling.
    
    Change-Id: I1de8e970b300354c0536aead65178401f140f509
    Reviewed-on: https://code.wireshark.org/review/1974
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5234972   Make socpe a local variable, can be used if we change the g_slist to a wmem_list.
    adds  5c48774   sip: avoid calling tvb_format_text() when tree is not visible.


Summary of changes:
 epan/dissectors/packet-sip.c |  195 ++++++++++++++++++++++++------------------
 1 file changed, 112 insertions(+), 83 deletions(-)