Wireshark · Wireshark-commits: [Wireshark-commits] master 09b5361: This fix now allows SASL/GSS-API with integrity only to be prope

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=09b5361302725cc83b7c8d76282441d031050c38
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

09b5361 by Richard Sharpe (realrichardsharpe@xxxxxxxxx):

    This fix now allows SASL/GSS-API with integrity only to be properly dissected
    in that we now properly indicate the checksum and provide the wrapped token to
    the LDAP dissector to dissect.
    
    There is still a problem in that the wrong parts of the SASL packet can be
    indicated when users click on some parts.
    
    I am committing it for review and because it is much better than the current
    code.
    
    Bug:9398
    Change-Id: I552fc249db26835b79abfc8793438a95f221663a
    Signed-off-by: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/1905
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  1f17d0c   Use the -Ox compiler option. Change-Id: I5d216d132485f6d2f8c63fa5a10b22e884e26b02 Reviewed-on: https://code.wireshark.org/review/1937 Reviewed-by: Evan Huus <eapache@xxxxxxxxx> Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    adds  09b5361   This fix now allows SASL/GSS-API with integrity only to be properly dissected in that we now properly indicate the checksum and provide the wrapped token to the LDAP dissector to dissect.


Summary of changes:
 asn1/spnego/packet-spnego-template.c |   37 +++++++++++++++++++++++++-----
 epan/dissectors/packet-ldap.c        |    5 ++++-
 epan/dissectors/packet-spnego.c      |   41 ++++++++++++++++++++++++++++------
 3 files changed, 70 insertions(+), 13 deletions(-)