Wireshark-commits: [Wireshark-commits] master 3d03216: packet-bencode: proto_tree_add_text -> somth
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 3 Jun 2014 12:39:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d03216edaf99b5770e2dfc5e818346125074b58
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3d03216 by Michael Mann (mmann78@xxxxxxxxxxxx):

    packet-bencode: proto_tree_add_text -> somthing filterable
    
    Also, cleanup dissector being called only with tree and a few tvb_new_subset calls.
    
    Change-Id: I1dab1b42ef1a27fc85b05d126f51f1582d7e5c58
    Reviewed-on: https://code.wireshark.org/review/1932
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  de9efa1   LLDP : Fix bug in mdi_power_source hf. While it compiles fine, hits an assert in add_string : failed assertion "hfinfo->type == FT_STRING || hfinfo->type == FT_STRINGZ || hfinfo->type == FT_STRINGZPAD"
    adds  3d03216   packet-bencode: proto_tree_add_text -> somthing filterable


Summary of changes:
 epan/dissectors/packet-bencode.c    |   98 ++++++++++++++++++++---------------
 epan/dissectors/packet-bittorrent.c |    2 +-
 epan/dissectors/packet-bzr.c        |   11 ++--
 epan/dissectors/packet-rtpproxy.c   |    2 +-
 4 files changed, 61 insertions(+), 52 deletions(-)