Wireshark-commits: [Wireshark-commits] master-1.12 1d20394: Fixed mausb valid bit & added invalid_v
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 24 May 2014 21:58:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d20394f6b7edaf2c609a1b1f24c227422a10f9c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

1d20394 by Sean O. Stalley (sean.stalley@xxxxxxxxx):

    Fixed mausb valid bit & added invalid_valid TFS
    
    Fixed valid bit check for MAUSB EPHandleResp packet. the valid bit
    is active low (ie: valid = 0, invalid = 1).
    
    I noticed Some other dissectors also defined an tfs_invalid_valid,
    so got rid of their local definitions & added it to epan/tfs.c.
    
    Change-Id: Ifd78325f9c7c046224073fc9b29e0cc60dc5c286
    Reviewed-on: https://code.wireshark.org/review/1766
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 33ae4cb024e36192ff7c6fa1d3d6bdcce9b25b7a)
    Reviewed-on: https://code.wireshark.org/review/1781
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c74afc3   Distinguish between "events" and "reports".
    adds  1d20394   Fixed mausb valid bit & added invalid_valid TFS


Summary of changes:
 epan/dissectors/packet-iec104.c |    1 -
 epan/dissectors/packet-mausb.c  |    2 +-
 epan/dissectors/packet-ppi.c    |    1 -
 epan/tfs.c                      |    1 +
 epan/tfs.h                      |    1 +
 5 files changed, 3 insertions(+), 3 deletions(-)