Wireshark-commits: [Wireshark-commits] master-1.10 45e901d: Use g_ alloced memory (instead of emem)
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 May 2014 02:49:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=45e901d44fb790d72b23cffb80bf4e47844462fc
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

45e901d by Michael Mann (mmann78@xxxxxxxxxxxx):

    Use g_ alloced memory (instead of emem) when printing fields.  emem shouldn't be used for GUI functions anyway.
    
    emem was exposed because of its memory limits trying to output PDML for a very large byte field in a capture file.
    
    When converting from proto_construct_match_selected_string to fvalue_to_string_repr remember proto_construct_match_selected_string includes fieldname + value, not just value
    
    Manually applied from I4fc6ea7fd1f63cff410207c8b30562771af40ada
    
    bug:10081
    Change-Id: Ie45f19a81fad25ae144e3bc5b5ad7d21b1f9c68c
    Reviewed-on: https://code.wireshark.org/review/1733
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  3057ffc   Rework debug_print_hash logic so that it's supported by older versions of perl.
    adds  45e901d   Use g_ alloced memory (instead of emem) when printing fields.  emem shouldn't be used for GUI functions anyway.


Summary of changes:
 print.c                     |   67 +++++++++++++------------------------------
 print.h                     |    2 +-
 ui/gtk/main.c               |    5 ++--
 ui/qt/main_window_slots.cpp |    4 ++-
 4 files changed, 27 insertions(+), 51 deletions(-)