Wireshark-commits: [Wireshark-commits] master b48a215: Don't use sizeof(guintN) for sizes of data i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 May 2014 21:55:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b48a21588a053e8c82b807b405c87306b5386b91
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b48a215 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use sizeof(guintN) for sizes of data in packets.
    
    Either
    
    	1) sizeof(guintN) = N/8, in which case it's redundant
    
    or
    
    	2) sizeof(guintN) != N/8, in which case it's wrong.
    
    This also keeps us from having to throw casts at complaints about
    shortening 64-bit values.
    
    Change-Id: I33911acfc54c0f3f21b73026a100a82b1ee2c35e
    Reviewed-on: https://code.wireshark.org/review/1731
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c4ca41e   RADIUS: Remove double space before type (t=...)
    adds  b48a215   Don't use sizeof(guintN) for sizes of data in packets.


Summary of changes:
 epan/dissectors/packet-6lowpan.c |  200 +++++++++++++++++++-------------------
 1 file changed, 100 insertions(+), 100 deletions(-)