Wireshark-commits: [Wireshark-commits] master bb01c7a: Remove extra parentheses.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 May 2014 17:44:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb01c7ac380a2978d8e1c5ca8fa7f2dd523a8323
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bb01c7a by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Remove extra parentheses.
    
    Fix the clang warning
    
    epan/wmem/wmem_allocator_simple.c:49:27: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
        if ((allocator->count == allocator->size)) {
             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    
    We might want to add -Wno-parentheses-equality to the compiler flag
    list but I'm not sure if doing so would hide valid problems.
    
    Change-Id: Id59b55af1411f13309fbec77870f869e04a6f49f
    Reviewed-on: https://code.wireshark.org/review/1717
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  a150988   Dissect Multicast Group Membership Information LCAF
    adds  bb01c7a   Remove extra parentheses.


Summary of changes:
 epan/wmem/wmem_allocator_simple.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)