Wireshark-commits: [Wireshark-commits] master 59eb8cf: Make (almost) all fields filterable and use
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 May 2014 05:34:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=59eb8cf404a0b2c77a9e13a7c205f6619675ce5d
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

59eb8cf by Michael Mann (mmann78@xxxxxxxxxxxx):

    Make (almost) all fields filterable and use "normal" dissection functions to do it.
    
    Removed the additional "parseFields" layer as it was unnecessary and IMO ends up creating more work for a developer if they want to add additional filterable fields.  That layer also hid the (large) number of unfilterable fields that were in the dissector that would normally be caught by counting the number of proto_tree_add_text function calls.
    
    Change-Id: I6f9607938c2386de40bdd3dae652614f07dda31e
    Reviewed-on: https://code.wireshark.org/review/1653
    Reviewed-by: Peter Ross <peter.ross@xxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  aa922b0   Try to fix stack-buffer-overflow caught by ASAN
    adds  59eb8cf   Make (almost) all fields filterable and use "normal" dissection functions to do it.


Summary of changes:
 epan/dissectors/packet-dis.c | 6841 ++++++++++++++++++++++--------------------
 1 file changed, 3559 insertions(+), 3282 deletions(-)