Wireshark · Wireshark-commits: [Wireshark-commits] master 4e82d2e: sigcomp: Add buffer check to STATE-ACCESS

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4e82d2e34fd9ff7c036a0a652163cbcd37b3363b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4e82d2e by Peter Wu (peter@xxxxxxxxxxxxx):

    sigcomp: Add buffer check to STATE-ACCESS
    
    Two conditions were not checked, state_length == 0 && state_begin != 0
    and the boundaries of the state buffer. The former is not a big deal,
    but the second issue causes a buffer overrun (detected by ASAN).
    
    The buffer size is supposed to be stored in the state buffer, that was
    not the case for the initial two SIP SDP and Presence state buffers.
    Fix a typo for presence_buf zero-ing while at it.
    
    Bug: 9601
    Change-Id: I41dde83185da60b670cca010ecc7b2a2aaaedeb9
    Reviewed-on: https://code.wireshark.org/review/1529
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a915de5   Fix build failures caused by lldp cleanup
    adds  4e82d2e   sigcomp: Add buffer check to STATE-ACCESS


Summary of changes:
 epan/sigcomp-udvm.c       |    1 +
 epan/sigcomp_state_hdlr.c |   35 +++++++++++++++++++++++++++--------
 2 files changed, 28 insertions(+), 8 deletions(-)