Wireshark-commits: [Wireshark-commits] master 16dfe11: Several tweaks to fast block allocator
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 May 2014 06:05:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=16dfe11b240f116c32ef488c3a88d32397ce2bb2
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

16dfe11 by Evan Huus (eapache@xxxxxxxxx):

    Several tweaks to fast block allocator
    
    - manually inline wmem_block_fast_add_to_block_list, it was only two lines and
      only called twice, so the function boilerplate was outweighing the abstraction
    
    - change free_all to release all but one block to the OS immediately, making gc
      a no-op; the alloc logic doesn't reuse later blocks anyways, so this was
      effectively a leak
    
    Change-Id: I033fbb2f3d87e58c7346cba10f2c710eaaa49e9f
    Reviewed-on: https://code.wireshark.org/review/1499
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bf3fbb3   Add dissector for 3GPP2 A21/S102 protocol.
    adds  16dfe11   Several tweaks to fast block allocator


Summary of changes:
 epan/wmem/wmem_allocator_block_fast.c |   69 ++++++++++++---------------------
 1 file changed, 24 insertions(+), 45 deletions(-)