Wireshark-commits: [Wireshark-commits] master 268104a: CaptureDialog: Fix IF type for user created
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Apr 2014 12:14:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=268104a1ddd476632b84008f33f70ec11cd95fc3
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

268104a by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    CaptureDialog: Fix IF type for user created pipe
    
     - If a user adds a pipe via "Capture Options"->"Manage Interfaces"
       ->"Pipes" the device.if_type.type is either not filled out (in
       the case if no other interfaces exist), or will be set to the
       last set if_type of the device queried by the iteration in line
       3537.
    
     - One could argue, that this is just a fixup, as still the issue
       remains, that the device structure will not be resetted, after
       the search for an already existing pipe element. Maybe a separate
       variable should be used for searching as it is used for adding
       the pipe
    
    Change-Id: Ia727bf3ce270a62d065e8c524a13768af389c346
    Reviewed-on: https://code.wireshark.org/review/1296
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  11b78ff   Kerberos: put PDU dissection under Kerberos tree and remove duplicate PDU name
    adds  268104a   CaptureDialog: Fix IF type for user created pipe


Summary of changes:
 ui/gtk/capture_dlg.c |    1 +
 1 file changed, 1 insertion(+)