Wireshark-commits: [Wireshark-commits] master 2d774c6: Minor cleanup
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 22 Apr 2014 15:00:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d774c6f84c690ee342b3baa0070c3d480df811d
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2d774c6 by Bill Meier (wmeier@xxxxxxxxxxx):

    Minor cleanup
    
    - Remove unneeded #includes;
    - Move proto_reg_handoff...(() to the end of the file as per convention;
    - Use dissector_add_handle() instead of using dissector_add_uint(..., 0, ...);
    - #if 0 an unused global function (which caused a [-Wmissing-prototypes] warning);
    - Remove an empty proto_reg-handoff...();
    - 'if (already_registered)' not required in one case.
    
    Change-Id: I74f267c2721df13eb4d52d7f19a6ded423218a39
    Reviewed-on: https://code.wireshark.org/review/1277
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  085b37d   Fix gcc "warning: no previous prototype ... [-Wmissing-prototypes]
    adds  2d774c6   Minor cleanup


Summary of changes:
 epan/dissectors/packet-lbm.c       |   13 +---
 epan/dissectors/packet-lbm.h       |    9 ---
 epan/dissectors/packet-lbmc.c      |   32 ++++------
 epan/dissectors/packet-lbmpdm.c    |   20 +-----
 epan/dissectors/packet-lbmpdmtcp.c |   58 ++++++++---------
 epan/dissectors/packet-lbmr.c      |   74 +++++++++++----------
 epan/dissectors/packet-lbtrm.c     |  124 ++++++++++++++++++------------------
 epan/dissectors/packet-lbtrm.h     |    7 --
 epan/dissectors/packet-lbtru.c     |   81 ++++++++++++-----------
 epan/dissectors/packet-lbtru.h     |    7 --
 epan/dissectors/packet-lbttcp.c    |   83 ++++++++++++------------
 epan/dissectors/packet-lbttcp.h    |    5 --
 12 files changed, 220 insertions(+), 293 deletions(-)