Wireshark-commits: [Wireshark-commits] master 48c77d8: Fix some bugs; Do more cleanup;
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Apr 2014 16:47:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=48c77d87106216cd3fd7e766bec9cfd791d1dfab
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

48c77d8 by Bill Meier (wmeier@xxxxxxxxxxx):

    Fix some bugs; Do more cleanup;
    
    Bugs fixed:
    - DISSECTOR_BUG (reported by proto.c) when displaying "Parameters"
       (Apparently introduced in I8de7a19 (gc538b44))
    - Incorrect byte pane highlighting for ARG_ARRAY container type
       (In dissector code as originally committed)
    - "uint32uint32" should be "uint32" in packet details.
       (In dissector code as originally committed)
    
    Cleanup:
    - Remove unneeded #includes;
    - Simplify some code;
    - Remove unneeded initializers;
    - Fix: "warning: no previous prototype...[-Wmissing-prototypes]"
    - Reformat hf[] array entries;
    - Fix some spelling;
    - Do indentation, whitespace & formatting style changes.
    
    Change-Id: If1f488f10ba83b27f75a1f71cf4bce7d5279e87c
    Reviewed-on: https://code.wireshark.org/review/1238
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    Tested-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  0102007   (Trivial) Clean up a comment; Fix spelling errors; Do some whitespace changes.
    adds  48c77d8   Fix some bugs; Do more cleanup;


Summary of changes:
 epan/dissectors/packet-alljoyn.c |  974 +++++++++++++++++++++++---------------
 1 file changed, 585 insertions(+), 389 deletions(-)