Wireshark-commits: [Wireshark-commits] master c531099: Try to fix bug 10000.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 17 Apr 2014 20:10:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c531099875dfc1abc7dff22424f30b4ef0c25b1f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c531099 by Guy Harris (guy@xxxxxxxxxxxx):

    Try to fix bug 10000.
    
    This involves duplicating macros, but at least it
    
    	1) doesn't have empty arguments to macros, which are apparently
    	   considered "undefined" by C90 and C++98
    
    and
    
    	2) doesn't involve "extern" applied to a definition rather than
    	   a declaration, which breaks building on some platforms (and
    	   which I think is also not legal C).
    
    Change-Id: I7eb98963a6d2e1bc9f869ebce3d7ba9228b6c9e4
    Reviewed-on: https://code.wireshark.org/review/1188
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f52626c   Add tvb_get and proto_tree_add for string-encoded byte arrays
    adds  c531099   Try to fix bug 10000.


Summary of changes:
 epan/value_string.h |   17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)