Wireshark · Wireshark-commits: [Wireshark-commits] master 65371b9: Fetch fields in NBDS as we add them to the protocol tree.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=65371b9f0ccfd8c76dde12c7173d32d21a21f439
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

65371b9 by Guy Harris (guy@xxxxxxxxxxxx):

    Fetch fields in NBDS as we add them to the protocol tree.
    
    That way, we don't throw an exception until we actually try to fetch a
    field that's not present, so that fields we *do* successfully fetch show
    up in the protocol tree.
    
    While we're at it, convert some proto_tree_add_text() fields to named
    fields.
    
    Change-Id: I22877dfaa0fe53c44f66e8f150a9f31ccd5aba37
    Reviewed-on: https://code.wireshark.org/review/1168
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d063b32   Fix "might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]" warning from gcc 4.9.
    adds  65371b9   Fetch fields in NBDS as we add them to the protocol tree.


Summary of changes:
 epan/dissectors/packet-nbns.c |  158 ++++++++++++++++++++++++-----------------
 1 file changed, 93 insertions(+), 65 deletions(-)